search

FXMisc / Flowless

Efficient VirtualFlow for JavaFX
BSD 2-Clause "Simplified" License
185 stars 38 forks source link

Make jar an OSGi bundle. #24

Closed timebowl closed 8 years ago

TomasMikula commented 8 years ago

Hi, thanks for the PR. How does the presence of this plugin affect the build (gradle build)? Does it generate a different jar, or does it just add some gradle task that can be used to make an OSGi bundle?

timebowl commented 8 years ago

From what I understand this particular plugin only replaces the default MANIFEST.MF (which currently only has the manifest version) with one that has the necessary OSGi metadata. From the plugin page: "The classes in the classes dir are analyzed regarding their package dependencies and the packages they expose."

So, same jar, but the extra metadata is ignored in non-OSGi environments.

This PR is the same as what was done with EasyBind: https://github.com/TomasMikula/EasyBind/commit/f8a9bc693a46cca0ec830af512b8a2a5241d427b

Thanks for the great work!

TomasMikula commented 8 years ago

:+1: