Changed estimatedScrollX/Y to return Var<Double> instead of Val<Double>.

FXMisc / Flowless

Efficient VirtualFlow for JavaFX

BSD 2-Clause "Simplified" License

185 stars 38 forks source link

Changed estimatedScrollX/Y to return Var<Double> instead of Val<Double>. #8

Closed JordanMartinez closed 8 years ago

TomasMikula commented 8 years ago

Looks good. I'm going to merge this, but maybe we should rename estimatedScrollXProperty(), estimatedScrollYProperty() to make it clearer that they are not pixel offsets.

JordanMartinez commented 8 years ago

I've always thought of scrollBar's not as pixel offsets but just values within the viewport. I know now that that's not true but I'm finding it hard to think of what a better name for these properties would be.

TomasMikula commented 8 years ago

You thought of it the right way, then, they are not pixel offsets. To me, scrollX sounds like it is the number of pixels scrolled. Good to know that to you it doesn't.