Closed Shreyas15srivatsa closed 1 year ago
@KnotScientific Same question as this
EDIT: Soccer events already have a timestamp created_at
. The above question does not apply.
@Shreyas15srivatsa @KnotScientific I kind of hijacked this task because it was relevant to my future tasks. PR -> #35
Let me know what you think of the changes.
@babrar your PR contains the Postgres DB schema changes, right? There's still changes needed on mantle and stats to fully complete this task, so don't move it to done after the PR has been merged in.
your PR contains the Postgres DB schema changes, right? There's still changes needed on mantle and stats to fully complete this task, so don't move it to done after the PR has been merged in.
@Shreyas15srivatsa It does contain pg db schema changes. However, there should be no breaking changes. I'm still testing to see if any postman request breaks 1nil as a result of this change.
@KnotScientific attaching a sport to a league will cause breaking changes atm --> https://github.com/FYDP-1nil/backend/pull/35#issuecomment-1442066125
@babrar: I'll checkout your branch and try to implement the code changes needed to make this work.
@Shreyas15srivatsa In that case, I have added a couple more changes to finalize the schema. git pull
before building on it.
Fixed breaking changes, PR ready for review.
PR merged in, noice job, men.