FYDP-1nil / backend

Fourth Year Design Project @ UWaterloo
https://www.eng.uwaterloo.ca/2023-capstone-design/electrical-computer/
3 stars 1 forks source link

Update Soccer db schema #5

Closed Shreyas15srivatsa closed 1 year ago

Shreyas15srivatsa commented 1 year ago

Image

babrar commented 1 year ago

@KnotScientific Same question as this EDIT: Soccer events already have a timestamp created_at. The above question does not apply.

babrar commented 1 year ago

@Shreyas15srivatsa @KnotScientific I kind of hijacked this task because it was relevant to my future tasks. PR -> #35

Let me know what you think of the changes.

Shreyas15srivatsa commented 1 year ago

@babrar your PR contains the Postgres DB schema changes, right? There's still changes needed on mantle and stats to fully complete this task, so don't move it to done after the PR has been merged in.

babrar commented 1 year ago

your PR contains the Postgres DB schema changes, right? There's still changes needed on mantle and stats to fully complete this task, so don't move it to done after the PR has been merged in.

@Shreyas15srivatsa It does contain pg db schema changes. However, there should be no breaking changes. I'm still testing to see if any postman request breaks 1nil as a result of this change.

babrar commented 1 year ago

@KnotScientific attaching a sport to a league will cause breaking changes atm --> https://github.com/FYDP-1nil/backend/pull/35#issuecomment-1442066125

Shreyas15srivatsa commented 1 year ago

@babrar: I'll checkout your branch and try to implement the code changes needed to make this work.

babrar commented 1 year ago

@Shreyas15srivatsa In that case, I have added a couple more changes to finalize the schema. git pull before building on it.

Shreyas15srivatsa commented 1 year ago

Fixed breaking changes, PR ready for review.

Shreyas15srivatsa commented 1 year ago

PR merged in, noice job, men.