FYDP-1nil / backend

Fourth Year Design Project @ UWaterloo
https://www.eng.uwaterloo.ca/2023-capstone-design/electrical-computer/
3 stars 1 forks source link

[DB] Write SQL scripts to generate/create new tables for basketball #6

Closed Shreyas15srivatsa closed 1 year ago

Shreyas15srivatsa commented 1 year ago

Task blocked until new table schema for additional sports is finalized.

Edit: As we discussed, the schema has now been finalized, so the task is unblocked.

Shreyas15srivatsa commented 1 year ago

Basketball schema - https://drive.google.com/file/d/1ei3dIQpFId-aT2XNg7LScsWOn4OABUm6/view American football schema - https://drive.google.com/file/d/14WGyYeweR_MhtuVwChezzE5OxJPBMTLZ/view

babrar commented 1 year ago

@KnotScientific I don't see a timestamp attribute for any of the GameEvent entities. Won't we need timestamps to show when the events happened in-game (for the scheduler service)?

KnotScientific commented 1 year ago

So in these two sports the time doesn't really matter as much as the period that they were scored in since scoring is so common. As long as we send in the period, that should be enough. The scheduler service won't be printing out any time.

Do we perhaps need a playType= start and ht to indicate to the scheduler that game has started or is half time? @babrar @Shreyas15srivatsa

babrar commented 1 year ago

Do we perhaps need a playType= start and ht to indicate to the scheduler that game has started or is half time?

I think that'd be useful. Half-time / Full-Time updates on social media are common.

babrar commented 1 year ago

Part 1 (basketball) PR -> https://github.com/FYDP-1nil/backend/pull/21

babrar commented 1 year ago

Breaking this into two parts. Each part requires its own 'review schema-> code -> review code' cycle.