FYSETC / FYSETC-ERB

This is dedicated controller board for VORON ERCF (EnragedRabbitProject)
44 stars 6 forks source link

selector endstop pin is reversed in fysetc 's hardware config file #6

Open ntchris opened 1 year ago

ntchris commented 1 year ago

selector endstop pin is defined reversed in fysetc 's hardware config file with the wrong ! symbol

wrong (current version of file) Select the endstop you want depending if you are using sensorless homing for the selector or not endstop_pin: !ercf:gpio24 # has ! , but shouldn't

According to klipper doc, https://www.klipper3d.org/Config_Reference.html Pin names may be preceded by ! to indicate that a reverse polarity should be used (eg, trigger on low instead of high). since the microswitch is normally closed, it's normally pulled down to GND (check fysetc's schematic J4), so it's normally LOW, with a ! , so it's normally triggered. wrong behaviour: when micro switch is not pressed, it's "triggered" from the command query_endstops.

correct setting: endstop_pin: ercf:gpio24 # remove the ! when micro switch is not pressed ( normally close) , it's "open" in command result query_endstops manual_stepper gear_stepper:open manual_stepper selector_stepper:open x:open y:open z:open because it's low (connected to gnd), so it's not triggered,

when micro switch is pressed ( open) , it's "triggered" in command result manual_stepper gear_stepper:open manual_stepper selector_stepper:TRIGGERED x:open y:open z:open because it's high, ( Not connected to gnd, pulled up by R9), so it's triggered,

eliwong commented 11 months ago

Thanks for the reminder, I will correct it.