search

FZJ-IEK3-VSA / FINE

The FINE python package provides a framework for modeling, optimizing and assessing energy systems
https://vsa-fine.readthedocs.io
Other
68 stars 39 forks source link

Inputoutput model #15

Closed l-kotzur closed 5 years ago

l-kotzur commented 5 years ago

Hey Dil,

thanks for adding the "createOutputAsNetCDF"-function!

In order not to overload the energySystemModel class, I moved it to the IOManagement-Folder. Could you test if this function is working for you?

If so, we could merge it to the develop branch.

Best Leander

l-welder commented 5 years ago

Thank you very much for your pull request Dilara!

One thing I noticed: In the doc string of the createOutputAsNetCDF function, the description of the last two arguments is missing but I guess they are not used in the code anyhow? Also, the default values are not described. In the code they are normally included via (for example):

:param optSumOutputLevel: output level of the optimization summary (see EnergySystemModel) |br| * the default value is 2 :type optSumOutputLevel: int (0,1,2)

For the return type, you write None but on the return type it says: "depends on the components in the energy system", could you have a look at that?

l-welder commented 5 years ago

@l-kotzur Thank you for your latest update of the code. The netcdfIO.py looks correct now, however the utils.py is not equal to the one which is currently on the develop branch. Could you have a look at that again? Thank you (:

l-welder commented 5 years ago

I adapted the parameters in the netcdf function such that they fit to the latest version of FINE. For this, I also fixed the optSummary in the Transmission component for which, somehow, the index column names went missing -.-. It should be possible now to call the netcdf function without an error as soon as the latest utils.py is merged.