search

FZJ-IEK3-VSA / FINE

The FINE python package provides a framework for modeling, optimizing and assessing energy systems
https://vsa-fine.readthedocs.io
Other
71 stars 40 forks source link

Metis fine #41

Closed l-kotzur closed 2 years ago

l-kotzur commented 2 years ago

Build is failing since anaconda is taking too long to get the requirements: @k-knosala @t-gross Didn't we switch to mamba?

l-kotzur commented 2 years ago

Build is failing since anaconda is taking too long to get the requirements: @k-knosala @t-gross Didn't we switch to mamba?

Obviously. Just need to take the gitlab-ci code.

k-knosala commented 2 years ago

Oh yes, I did not have a look at the travis.yml when switching. Hope that it will pass now.

codecov-commenter commented 2 years ago

Codecov Report

Merging #41 (9de848b) into master (3114fd0) will increase coverage by 6.96%. The diff coverage is 77.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   63.00%   69.97%   +6.96%     
==========================================
  Files          21       31      +10     
  Lines        4547     5739    +1192     
==========================================
+ Hits         2865     4016    +1151     
- Misses       1682     1723      +41
Impacted Files Coverage Δ
FINE/IOManagement/exploitOutput.py 14.28% <0.00%> (-5.72%) :arrow_down:
FINE/component.py 91.00% <ø> (+1.07%) :arrow_up:
FINE/utils.py 67.22% <ø> (+1.26%) :arrow_up:
FINE/expansionModules/robustPipelineSizing.py 5.16% <5.93%> (-0.22%) :arrow_down:
FINE/IOManagement/standardIO.py 21.25% <16.17%> (-0.91%) :arrow_down:
FINE/subclasses/lopf.py 89.02% <68.96%> (+67.07%) :arrow_up:
FINE/spagat/RE_representation_utils.py 69.76% <69.76%> (ø)
FINE/subclasses/conversionPartLoad.py 85.11% <75.60%> (ø)
FINE/IOManagement/utilsIO.py 77.69% <77.69%> (ø)
FINE/subclasses/DSM.py 88.97% <82.25%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3114fd0...9de848b. Read the comment docs.

t-gross commented 2 years ago

I fixed the travis.yml (use of the correct environment name). Tests are successful, now. Thanks @l-kotzur for adapting!

l-kotzur commented 2 years ago

@t-gross @Shruthi-Patil Which ToDos are open such that we can merge?

Shruthi-Patil commented 2 years ago

@l-kotzur there is a bug in the netcdf feature that needs fixing. Apart from that we're good to go

t-gross commented 2 years ago

Changes are updated in another branch for next FINE release.