search

FZJ-IEK3-VSA / FINE

The FINE python package provides a framework for modeling, optimizing and assessing energy systems
https://vsa-fine.readthedocs.io
Other
68 stars 39 forks source link

[JOSS] Gitlab contents #48

Open GregorBecker opened 6 months ago

GregorBecker commented 6 months ago

Hi this is a question regarding the issue templates and files related to gitlab from JOSS Review 6274.

While quickly scanning your repository I've found a ".gitlab"-folder providing a templates for issue. Why don't you use them within your github-repository. Otherwise I would recommend removing them from the repository because they are not relevant for the presented software.

The same problem occurs with .gitlab-ci.yml.

Kind regards @GregorBecker

maurerle commented 5 months ago

As someone not related to this repository but with general development experience: It is quite common to mirror a repository and have an internal version available on some other git server. Due to the consequent way git archives files and puts hashes across the history of a file tree, it is not easily feasible to have this folder available in one VCS but not available in the other VCS.

The same goes for the .gitlab-ci.yml which might run on some mirror on some other git-server without relying on resources of GitHub. So I do not think, that there is need to change this in any way.