search

FZJ-IEK3-VSA / HiSim

HiSim - House Infrastructure Simulator
MIT License
27 stars 14 forks source link

Do not use string comparision in dynamic_component #317

Open k-knosala opened 4 months ago

k-knosala commented 4 months ago

Hey,

the dynamic componennt compares inputs and outputs by comparing their names as far as I understand.

Imo this approach leads to problems when adding more channels.

Is there another way to solve this?

https://github.com/FZJ-IEK3-VSA/HiSim/blob/1ab0f639a938075ce4e3617c4d834433e1cfa885/hisim/dynamic_component.py#L184C1-L197C12