search

FZJ-IEK3-VSA / HiSim

HiSim - House Infrastructure Simulator
MIT License
27 stars 14 forks source link

Problem with automatic connection in ems controller #338

Open Hoppe-J opened 2 weeks ago

Hoppe-J commented 2 weeks ago

EMS Controller create automatically outputs for battery, advanced hp, modular hp, even components are not in system setup. When using more advanced hp, ems controller test failed, due to incorrect energy balance, because energy is devided to advanced hp and more advanced hp. In addition, when connecting components to ems manually, aotimatic connection will be also there, so components are twice in outputs. When comment automatic connection in ems model out, and connect ems manually with components, everthing works fine.

Screenshot 2024-06-20 191508

k-rieck commented 3 days ago

The problem here is that the EMS adds outputs in some of its default connections. As the default connections are called in the init function of the EMS, these outputs are added to self.all_outputs as soon as the EMS is initiated. What we want is to have these outputs only added when a default connection is made (when connect_automatically=True).