FZJ-INM1-BDA / siibra-explorer

Apache License 2.0
22 stars 4 forks source link

Metadata of downloaded files incomplete #1376

Open dickscheid opened 1 year ago

dickscheid commented 1 year ago

When downloading parcellation maps from the web application, the download folder contains markdown and text files with too little information:

dickscheid commented 1 year ago

Related comments:

xgui3783 commented 1 year ago

siibra-explorer uses space/parcellation's description and publication properties to popuate description and citation.[1] If they are missing in the download bundle, that means it is missing in siibra-python.

We will fix this issue at relevant places ASAP.

License is completely missing, yes. We are aware of the issue and will address it ASAP.

sometimes link to online resource missing (e.g. knowledge graph dataset link)

We are already aware of this issue, and a fix is on the way.

I suggest to merge all metadata into the README instead of shipping one markdown file per downloaded file. The readme should describe all files in the downloaded package.

When downloading a probability, I would not include the maxprobmap as.a NIfTI. The package should just provide what the user saw in the view - the template, the probability map.

We will see to it that these to be done.

[1] https://github.com/FZJ-INM1-BDA/siibra-api/blob/v0.3.10/api/common/data_handlers/compounds/download.py#L58-L68

xgui3783 commented 1 year ago

depends on https://github.com/FZJ-INM1-BDA/siibra-python/issues/411 and https://github.com/FZJ-INM1-BDA/siibra-python/issues/412