search

FZJ-INM1-BDA / siibra-python

Software interfaces for interacting with brain atlases - Python client
Apache License 2.0
48 stars 10 forks source link

Fix assigning uncertain points to labelled maps #526 #531

Closed AhmetNSimsek closed 8 months ago

AhmetNSimsek commented 8 months ago

During refactoring (https://github.com/FZJ-INM1-BDA/siibra-python/pull/480/commits/6fe6fa6f4955342cdd0a76a2076d3594493442b9), image resampling was forgotten to be replaced. This fixes volume assignments to labelled maps.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 1298 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (36fe3d5) 50.48%. Report is 330 commits behind head on main.

Files Patch % Lines
siibra/features/feature.py 47.89% 124 Missing :warning:
siibra/volumes/volume.py 44.17% 115 Missing :warning:
siibra/explorer/url.py 0.00% 107 Missing :warning:
siibra/volumes/parcellationmap.py 20.30% 106 Missing :warning:
siibra/core/region.py 62.50% 90 Missing :warning:
siibra/retrieval/datasets.py 49.53% 54 Missing :warning:
...bra/features/connectivity/regional_connectivity.py 27.39% 53 Missing :warning:
siibra/explorer/util.py 0.00% 51 Missing :warning:
...a/features/tabular/regional_timeseries_activity.py 25.00% 48 Missing :warning:
siibra/configuration/factory.py 54.83% 42 Missing :warning:
... and 37 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## =========================================== + Coverage 36.81% 50.48% +13.66% =========================================== Files 61 69 +8 Lines 5421 6501 +1080 =========================================== + Hits 1996 3282 +1286 + Misses 3425 3219 -206 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.