FZJ-INM1-BDA / siibra-python

Software interfaces for interacting with brain atlases - Python client
Apache License 2.0
48 stars 10 forks source link

Maint: `volume.fetch` #562

Closed AhmetNSimsek closed 7 months ago

AhmetNSimsek commented 7 months ago

During the last refactoring, this method has been changed a few times, leaving some artifacts and small issue to resolve. This PR addresses these.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 1305 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (3ddcb1e) 53.29%. Report is 387 commits behind head on main.

Files Patch % Lines
siibra/features/feature.py 48.55% 125 Missing :warning:
siibra/volumes/volume.py 43.89% 124 Missing :warning:
siibra/core/region.py 56.75% 112 Missing :warning:
siibra/volumes/parcellationmap.py 18.97% 111 Missing :warning:
siibra/explorer/url.py 0.00% 107 Missing :warning:
...bra/features/connectivity/regional_connectivity.py 33.33% 56 Missing :warning:
siibra/retrieval/datasets.py 49.53% 54 Missing :warning:
siibra/explorer/util.py 0.00% 51 Missing :warning:
...a/features/tabular/receptor_density_fingerprint.py 4.54% 42 Missing :warning:
...a/features/tabular/regional_timeseries_activity.py 39.13% 42 Missing :warning:
... and 36 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #562 +/- ## =========================================== + Coverage 36.81% 53.29% +16.47% =========================================== Files 61 69 +8 Lines 5421 6638 +1217 =========================================== + Hits 1996 3538 +1542 + Misses 3425 3100 -325 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.