Closed AhmetNSimsek closed 7 months ago
Attention: 1305 lines
in your changes are missing coverage. Please review.
Comparison is base (
5a0e6b3
) 36.81% compared to head (3ddcb1e
) 53.29%. Report is 387 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
During the last refactoring, this method has been changed a few times, leaving some artifacts and small issue to resolve. This PR addresses these.
parcellationmap.Map.fetch()
but this is going to be removed as it is not it's job.) (Alternatively, the fetch can fail at, sayNiftiProvider.fetch()
but it is not user's job to know which formats are shipped with different resolutions. And since we decided against resampling nifti images if resolution_mm is supplied, this seems to be the best solution at the moment.)formats
property should only list actual formats otherwise recursion occurs.