search

FZJ-INM1-BDA / siibra-python

Software interfaces for interacting with brain atlases - Python client
Apache License 2.0
46 stars 8 forks source link

fix: write lock for warmup #563

Closed xgui3783 closed 4 months ago

xgui3783 commented 4 months ago

Since warmup writes files, it is potentially possible to have multiple process trying to warmup simultaneously.

This PR prevents simultaneous write by using a FileLock (or SoftFileLock in windows).

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5a0e6b3) 36.81% compared to head (739d7c7) 53.31%. Report is 394 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #563 +/- ## =========================================== + Coverage 36.81% 53.31% +16.49% =========================================== Files 61 69 +8 Lines 5421 6645 +1224 =========================================== + Hits 1996 3543 +1547 + Misses 3425 3102 -323 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xgui3783 commented 4 months ago

fixed comments

@AhmetNSimsek can you take a look again?