search

FZJ-INM1-BDA / siibra-python

Software interfaces for interacting with brain atlases - Python client
Apache License 2.0
46 stars 8 forks source link

Add Volume.evaluate_points() and fix voxel access for _points_inside #566

Closed dickscheid closed 4 months ago

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 62.50000% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 53.52%. Comparing base (5a0e6b3) to head (b83aa45). Report is 424 commits behind head on main.

Files Patch % Lines
siibra/volumes/volume.py 63.63% 12 Missing :warning:
siibra/livequeries/bigbrain.py 0.00% 10 Missing :warning:
siibra/core/region.py 0.00% 5 Missing :warning:
...bra/features/tabular/bigbrain_intensity_profile.py 0.00% 2 Missing :warning:
siibra/locations/__init__.py 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #566 +/- ## =========================================== + Coverage 36.81% 53.52% +16.70% =========================================== Files 61 69 +8 Lines 5421 6726 +1305 =========================================== + Hits 1996 3600 +1604 + Misses 3425 3126 -299 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

AhmetNSimsek commented 4 months ago

I think we should also consider using evaluate_points instead of parcelationmap.Map._read_voxel