Closed AhmetNSimsek closed 2 months ago
note: waiting on me (@xgui3783 ) to create a preview viewer/api instance
additional regression not covered by tests
some features now have duplicated ids
sample code (tested for 35585fe3eb852335490737a476be49e315f16395 ):
import siibra
siibra.cache.clear()
region = siibra.get_region("cortical layer", "1 left")
f, = siibra.features.get(region, "cell density profile")
print(len([_ for _ in f]), len({_.id for _ in f})) # prints 5 3
@AhmetNSimsek are the new commits meant to address https://github.com/FZJ-INM1-BDA/siibra-python/pull/568#issuecomment-1966356183 ?
@AhmetNSimsek are the new commits meant to address #568 (comment) ?
Indeed! I forgot to ping you, sorry.
Attention: Patch coverage is 46.15385%
with 63 lines
in your changes are missing coverage. Please review.
Project coverage is 51.64%. Comparing base (
5a0e6b3
) to head (8da694f
). Report is 492 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
data
and averaged graphs decided to be added in the dev meeting on 22.02.2024Please use https://github.com/FZJ-INM1-BDA/siibra-configurations/tree/use_v04_feature_ids for configuration to test.