search

FZJ-INM1-BDA / siibra-python

Software interfaces for interacting with brain atlases - Python client
Apache License 2.0
46 stars 8 forks source link

fix: memory usage when warming the cache #589

Closed xgui3783 closed 2 months ago

xgui3783 commented 2 months ago

Current implementation of warming data results in memleak (well, we call it in memory caching)

this PR fixes this, and the memory foot print is consistently < 1G when warming the cache. For comparison, without this PR, memory footprint goes beyond 4G, when the process is OOM killed.

xgui3783 commented 2 months ago

it looks like MRIVolumeOfInterest etc does not have plot implemented, thus the e2e failing.

Should we remove them from the plot testing list?

@AhmetNSimsek

AhmetNSimsek commented 2 months ago

it looks like MRIVolumeOfInterest etc does not have plot implemented, thus the e2e failing.

Should we remove them from the plot testing list?

@AhmetNSimsek

Ah yes. Would you mind making the change? Also, please feel free to add more tests to ensure features in the explorer have plots.