FZJ-INM1-BDA / voluba

Browser based tool for interactive alignment of high-resolution volumes of interest to 3D reference brain models
https://voluba.readthedocs.io
Apache License 2.0
4 stars 0 forks source link

WebAlign and VoluBA allow submission of registration results to EBRAINS curation #132

Open xgui3783 opened 2 years ago

xgui3783 commented 2 years ago

per roadmap https://ebrains.eu/services/atlases/#services

fsdavid commented 1 year ago

Can we elaborate?

xgui3783 commented 1 year ago

this is probably what @JThoennissen and Lyuba & co were discussing: how to integrate the output of voluba (registration of volume to template) back to ebrains

dickscheid commented 1 year ago

There is a detailed documentation of the proposed workflow under this internal link

JThoennissen commented 1 year ago

According to discussion with @dickscheid @xgui3783, the following needs to be done by end of month:

xgui3783 commented 1 year ago

fix: "Start time"

does not seem to be broken, so not modified

store the type of transformation ("Technique" or "Description" in DataAnalysis)

since user can add custom description, this can be considered met. Otherwise, we probably should add the relevant analysis technique in controlled/voluba space

let the user optionally paste a KG-URL to link the DataAnalysis to an existing dataset

since user can add custom description, this can be considered met. Otherwise, datanalysis schema does not seem to support dataset version

JThoennissen commented 1 year ago

let the user optionally paste a KG-URL to link the DataAnalysis to an existing dataset

This should be rather done together with the possibility to choose datasets for anchoring directly from the KG. This means: At the beginning, query for all DatasetVersion instances available in the KG and let the user choose a Dataset. Then for this dataset, query all File instances and let the user choose the actual file. This way, we can explicitly link the file to the DataAnalysis.

xgui3783 commented 1 year ago

let the user optionally paste a KG-URL to link the DataAnalysis to an existing dataset

This should be rather done together with the possibility to choose datasets for anchoring directly from the KG. This means: At the beginning, query for all DatasetVersion instances available in the KG and let the user choose a Dataset. Then for this dataset, query all File instances and let the user choose the actual file. This way, we can explicitly link the file to the DataAnalysis.

This makes sense.

To achieve this we will need to:

xgui3783 commented 1 year ago

I have some bad news.

The proposed workflow:

1/ User searches (with string or uuid) dataset version

2/ User confirms the dataset version they would like to use

3/ User searches File by uuid or name

4/ User selects File

Between 2/ and 3/ , to get from DatasetVersion to File the traversal appears to be the following:

DatasetVersion -> FileRepository -> File

DatasetVersion -> FileRepository is already plenty slow, but FileRepository -> File is ... very very slow (see https://github.com/HumanBrainProject/fairgraph/issues/57) With the tests I did just now, it took 30 seconds to fetch two files from https://search.kg.ebrains.eu/?category=Dataset#87c6dea7-bdf7-4049-9975-6a9925df393f , as an example.

This would not be a very user friendly work flow.

JThoennissen commented 1 year ago

Lyuba said that we could ask Oliver Schmid, maybe he has a solution ... I will write an email today.

xgui3783 commented 1 year ago

There is a known issue at https://github.com/HumanBrainProject/fairgraph/issues/57 which describes the same issue.