Closed kwhat closed 4 years ago
Hey @FaaPz,
Good to hear from you! I have no preference so I will take a look at both and pick the path of least resistance.
Hey @FaaPz,
I am going to start trying out CI with github actions. The current CI stuff in styleci needs to be relaxed for a couple of things as they are in violation of PSR-12. This seems to mostly cover the spaces between string concat operator .
and space after anonymous class. Please See https://github.com/FaaPz/PDO/pull/121
Also, can you enable github actions for this repo?
Hi @kwhat, I’ve just enabled GitHub Actions. ✅
@FaaPz, Good deal! Looks like CI is running some linting and unit tests. I haven't figured out a way to export the coverage report artifact yet, but the rest of it is working across Linux, OSX and Windows. There are still those problems with the CI Style check PSR-12 conflicts I previously mentioned. The internal linting covers must of the stuff currently in the Style CI check so up to you if you want to keep it.
@kwhat Awesome!
I’ve just disabled StyleCI for the time being. Maybe we’ll get rid of it later.
@FaaPz,
Hope you are doing well. I am almost done adding unit tests to the master branch. I was wondering what service provides pull-request checks and if it would be possible to run
composer test
as part of that process? If not, maybe Circle CI?