FaaPz / PDO

Just another PDO database library
MIT License
316 stars 103 forks source link

Update Testing Process #114

Closed kwhat closed 4 years ago

kwhat commented 5 years ago

@FaaPz,

Hope you are doing well. I am almost done adding unit tests to the master branch. I was wondering what service provides pull-request checks and if it would be possible to run composer test as part of that process? If not, maybe Circle CI?

$ composer test
> phpunit --coverage-html build/coverage tests/
PHPUnit 8.2.5 by Sebastian Bergmann and contributors.

.................................SS......SSS.....SSS.....S        58 / 58 (100%)

Time: 908 ms, Memory: 8.00 MB

OK, but incomplete, skipped, or risky tests!
Tests: 58, Assertions: 67, Skipped: 9.

image

FaaPz commented 5 years ago

Hi @kwhat,

I appreciate your involvement in this project! 😄

Currently, there’s no testing process whatsoever. The only service in use is for code styling (StyleCI).

We could enable Circle CI as you’ve mentioned, or Travis CI, or some other service — what’s your preference?

kwhat commented 5 years ago

Hey @FaaPz,

Good to hear from you! I have no preference so I will take a look at both and pick the path of least resistance.

kwhat commented 5 years ago

Hey @FaaPz,

I am going to start trying out CI with github actions. The current CI stuff in styleci needs to be relaxed for a couple of things as they are in violation of PSR-12. This seems to mostly cover the spaces between string concat operator . and space after anonymous class. Please See https://github.com/FaaPz/PDO/pull/121

kwhat commented 5 years ago

Also, can you enable github actions for this repo?

FaaPz commented 5 years ago

Hi @kwhat, I’ve just enabled GitHub Actions. ✅

kwhat commented 5 years ago

@FaaPz, Good deal! Looks like CI is running some linting and unit tests. I haven't figured out a way to export the coverage report artifact yet, but the rest of it is working across Linux, OSX and Windows. There are still those problems with the CI Style check PSR-12 conflicts I previously mentioned. The internal linting covers must of the stuff currently in the Style CI check so up to you if you want to keep it.

FaaPz commented 5 years ago

@kwhat Awesome!

I’ve just disabled StyleCI for the time being. Maybe we’ll get rid of it later.