FaaPz / PDO

Just another PDO database library
MIT License
316 stars 103 forks source link

StyleCI incompatible with new PSR-12 #127

Closed kwhat closed 4 years ago

kwhat commented 4 years ago

Hi @FaaPz,

I have gotten the builds working again, minor upstream breakage. Any way we can loosen up the string concatenation spacing? We appear to be in conflict with the PSR-12 standard.

https://github.styleci.io/analyses/644xaP?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

FaaPz commented 4 years ago

StyleCI doesn't have a PSR-12 preset yet. 🤓

We could disable StyleCI for the time being? Otherwise, it will take some time to check which PHP fixers to use and those we shouldn't.

kwhat commented 4 years ago

Ha! Too bleeding edge. We can just leave it for the time being. All the windows and mac builds / tests are all failing right now anyway. I will ping you again in a while ;)

FaaPz commented 4 years ago

I've disabled StyleCI completely for now, but their PSR-12 preset is in beta. 🙌

kwhat commented 4 years ago

Nice! If want to add more restrictions, phpcs has a whole lot I've currently disabled. Just let me know.