search

Fab1en / rocket-chat-rest-client

Rocket Chat REST API client in PHP
49 stars 38 forks source link

How to contribute my local changes #8

Open marco-aa opened 7 years ago

marco-aa commented 7 years ago

Dear Devs,

i made a local clone and created a local branch and made my changes/contributions. (Added update method for Userclass and added optional field customFields for update and create)

How can i contribute to you/here ? Normaly i push my branch and make a pull request.

Fab1en commented 7 years ago

Great ! Go for it, feel free to make pull requests. There is no guideline for contributors, we would have to build one together.

marco-aa commented 7 years ago

I would like to :) Do i have to fork first and push my changes into my fork and than i have to make a pull request ? Or is there a easyer way - because i'm not a member ob Fab1en-rocket-chat-rest-client git repository ?

I hope this questions is not so newbeey like - it's the first time a work an github in this way

Fab1en commented 7 years ago

Yes, you have to fork first, push your changes to your own fork and then make the pull request. That's what @alekseykuleshov did (he seams to have deleted his repo afterwards). I found this question on Stack Overflow that would perhaps help you.

marco-aa commented 7 years ago

Worked like charme - done ;)