Refactor Serializer -> ValueSerializer

FabLabsMC / fiber

A configuration system. Maintained by @zeroeightysix and @Pyrofab

Apache License 2.0

32 stars 8 forks source link

Refactor Serializer -> ValueSerializer #59

Closed kvverti closed 4 years ago

kvverti commented 4 years ago

Closes #58 . Turns out SerializableType#getGenericPlatformType isn't actually used.. shrug.

Replaces Serializer with a visitor-style ValueSerializer.
Fiber handles serializing and deserializing.
No need for serialization libraries to use hacky reflection.
- Serialization libraries only need to be able to serialize a heterogeneous collection of numbers, strings, booleans, lists, and maps.
Replace JanksonSerializer and its tests with JanksonValueSerializer.

Pyrofab commented 4 years ago

Another thought : we could combine TypeSerializer and ValueSerializer into a single interface taking 2 targets (IR and user-facing) so that we can (de)serialize an entire configuration in a single pass. The current TypeSerializer methods would be moved into the new interface, to allow serializing the intermediate representation only.