search

FabLabsMC / fiber

A configuration system. Maintained by @zeroeightysix and @Pyrofab
Apache License 2.0
32 stars 8 forks source link

Float default value is an int, causing crashes #89

Open gamma-delta opened 2 years ago

gamma-delta commented 2 years ago

Hello,

People have been getting a lot of issues like this on Hexcasting: https://pastebin.com/Bbb3GWib

io.github.fablabsmc.fablabs.api.fiber.v1.exception.FiberConversionException: Invalid serialized value 0

The rub here is that, in the hexcasting-client.json5 config, it is set to 0.5.

Is this an issue on my side? Here's the line where it's crashing in Hexcasting. (Note there's a Mth.clamp that should fix up issues where Fiber successfully loads a 0 value.)

gamma-delta commented 2 years ago

See https://github.com/gamma-delta/HexMod/issues/274, https://github.com/gamma-delta/HexMod/issues/255, https://github.com/gamma-delta/HexMod/issues/164, many others

ProfanedBane commented 2 years ago

Might have found a fix, it's seemingly caused by the version of Java that the Curse Launcher shipped, getting players to change to Adoptium openJDK resolves it.

gamma-delta commented 2 years ago

Yahoo what a blast

I'm gonna leave this open in case there's something the Fiber people can do about it also but thanks for the fix!

iepathos commented 1 year ago

Still an issue with latest java for me

ProfanedBane commented 1 year ago

Still an issue with latest java for me

What Java vendor are you using?

iepathos commented 1 year ago

I tried Adoptium openJDK 17.0.5.8

ProfanedBane commented 1 year ago

Good to know that rules it out as a 100% fix, I've had it work on the 3 or so people I've had test it so far so I was unaware it might not work for everyone.