search

FabMo / FabMo-Engine

The FabMo Engine - A software and apps ecosystem for digital fabrication.
http://gofabmo.org/
Apache License 2.0
55 stars 22 forks source link

clears up stops from inputs in probe and goto #1111

Closed tedh-shopbot closed 11 months ago

tedh-shopbot commented 11 months ago

This PR further operationalizes input switch "Actions" for LIMIT and INTERLOCK. These are actions managed through FabMo, based on inputs that trigger simple feedholds in G2. This work is a continuation of PR #1093, clearing up the action of Stop, Limit, Interlock when hit fin a GoTo from the keypad or with a Probing move from OpenSBP runtime. In both cases they should offer the user the same Resume/Option as with a Stop from the interface. It also fixes some small issues including starting a probe move close to the target.

I have tested a subset of the possibilities described in the chart attached to #1093 but mostly have focused on the behavior of the Keypad Goto. It is not yet as robust as I would like to see it. Occasionally a misbehavior seems to occur as a result of the timing of user actions. It needs some more work. Also note that the transfer of speeds to the Goto function from the slider requires a move having been made with the keys -- this needs fixing.

Remember these changes require the last PR in the G2 to work and that a probe command cannot be followed immediately with a PAUSE when a limit switch is used to trigger the probe. This means the current C3 and C10 need some edits.

Sorry this is not an automatic merge :(

kyle-kingsbury commented 11 months ago

Tested extensively with UI stop button and input feedhold. Homing, Z zeroing, stopping during gotos, stopping during probing. Then ran some files in which I stopped and resumed using both stop methods as well. There were some minor UI behaviors that I will report separately, but overall looks good.