search

Fabian-Sommer / HeroesLounge

https://heroeslounge.gg
MIT License
16 stars 11 forks source link

Use Blizzard OAuth #9

Open Fabian-Sommer opened 6 years ago

rogusdev commented 5 years ago

Do you mean instead of the laravel/October cms auth system? Or as an option somehow?

Fabian-Sommer commented 5 years ago

Ideally, people are able to log in with their battle.net accounts.

Fabian-Sommer commented 5 years ago

Can be in addition to what we have right now or replacing it, seeing as everyone has to have a bnet account as is

Astraeus- commented 5 years ago

Do we want people to login with their battle.net accounts though? I thought this was mainly for validating the battletag and as proof of access to the account, as well as preparation for the promised Blizzard api at the time.

rogusdev commented 5 years ago

Is this bnet class perhaps applicable here? plugins\rikki\heroeslounge\classes\oauth\bnet.php (btw clientId and clientSecret really should not live in the codebase -- can you set up env vars on your hosting provider?)

There are plugins for oauth providers, perhaps one already supports bnet? e.g. https://www.twilio.com/blog/add-facebook-twitter-github-login-laravel-socialite

Astraeus- commented 5 years ago

I recall there being a start with socialite in the oauth class, but I don't know how far / useful that code is