search

FabianBeiner / PHP-IMDB-Grabber

This PHP library enables you to scrape data from IMDB.com.
MIT License
271 stars 160 forks source link

Fix: getTVInfo #198

Closed FLIKI closed 4 months ago

FLIKI commented 4 months ago

A new mechanism for retrieving TV episodes is needed due to changes in the IMDb layout.

FabianBeiner commented 4 months ago

Thanks for this fix. Can you please try to stick to the coding style (which is wild, I know, but at least try to use camelCase and stuff like that)? Besides, instead of a hard-coded 'n/A', please use self::$sNotFound. I'll merge it afterward.

FLIKI commented 4 months ago

I changed the variables and the defaults. There is probably a cleaner way to write the 'set defaults', but this also works.

FabianBeiner commented 4 months ago

I changed the variables and the defaults. There is probably a cleaner way to write the 'set defaults', but this also works.

That whole codebase is anything but clean, so this will do it. Thanks! ;)