search

FabianRig / ArduinoMoonBoardLED

LED system compatible with MoonBoard based on Arduino Nano 33 BLE
GNU General Public License v3.0
71 stars 14 forks source link

New moonboard app doesn't light up green blue lights #12

Closed sintoris closed 1 year ago

sintoris commented 1 year ago

I finished building my mini moonboard last week, just about when the new moonboard app was released. The old app works great with this project. With the new app, only the start (green/violet) and finish (red) holds are lighted up. The holds in between remain dark.

Any clues as to what could be wrong?

PS: Thanks for this great project!

sintoris commented 1 year ago

This was easy to fix. Just changed "P" to "R" in main.cpp:157 and :198.

In the new moonboard app the progress holds are marked with "R". In the old app it was with "P".

For example, for the problem "70-250!" the problem strings are: Old app Problem string: S74,S114,P39,P103,E11,E60 New app Problem string: S74,S114,R39,R103,E11,E60

FabianRig commented 1 year ago

Thanks for letting us know! I assume you're using an iPhone? I don't remember seeing an update for my Android device.

I'm on vacation at the moment and don't have access to my laptop. Therefore I can't fix it right now.

However, I'd suggest we change both lines to an OR statement and check for both P and R. Like that, the project works with any version.

sintoris commented 1 year ago

No I am using Android. The old app has been silently removed from the play store last week. A new app has appeared with slightly different icon. One can actually have them both installed side by side but only if you have had installed the old app before last week. Confusingly the version numbering has restarted from 1.x with the new app. The old one stopped at 8.something.

I think there is no need to keep both P and R in the code. First, one cannot install the old app anymore. Second, even if you have the old app installed, you can't log any sent problems with it anymore. At least that's the case with me.

marcosncosta1 commented 1 year ago

Nice catch. I am about to start on the project. I will make the changes in the code as suggested

OllieCMartin commented 1 year ago

The new app introduces 'show move beta', @sintoris is right about just changing "P" to "R" during normal operation, but when show beta is on you get additional holds/colours:

"L" -> lefthand "R" -> Righthand "M" -> Match hands "F" -> footholds

so you have S, R, L, M, F, E hold types now!

Easy enough to fix, I'm not sure what the right colours should be so I ended up just making them up!

FabianRig commented 1 year ago

Thank you all for bringing this up!

I've found some new problems with included beta and updated the code accordingly.

It should work as expected now. Please let me know if you encounter any issues!

FabianRig commented 1 year ago

I'm closing this issue because it should be fixed. Feel free to open a new one if there are any issues.