FabianTerhorst / coreclr-module

Old alt:V CoreClr (.NET Core Common Language Runtime) community made module. New: https://github.com/altmp/coreclr-module
MIT License
72 stars 67 forks source link

Alt.OnCheckpoint always returns True as state #759

Closed WhishN closed 1 year ago

WhishN commented 1 year ago
private void OnCheckpoint(ICheckpoint checkpoint, IWorldObject target, bool state)
    {
        CustomLog.Debug($"OnCheckpoint {checkpoint} {target} {state}");
        state = checkpoint.IsEntityIdIn(target.RemoteId);
        CustomLog.Debug($"OnCheckpoint {checkpoint} {target} {state}");
    }
    will result in 
// Enter
 OnCheckpoint AltV.Net.Client.Elements.Entities.Checkpoint AltV.Net.Client.Elements.Entities.LocalPlayer True
 OnCheckpoint AltV.Net.Client.Elements.Entities.Checkpoint AltV.Net.Client.Elements.Entities.LocalPlayer True
 // Exit
 OnCheckpoint AltV.Net.Client.Elements.Entities.Checkpoint AltV.Net.Client.Elements.Entities.LocalPlayer True
 OnCheckpoint AltV.Net.Client.Elements.Entities.Checkpoint AltV.Net.Client.Elements.Entities.LocalPlayer False

tested on [latest RC ](alt:V Server 15.0-rc1 (rc))

Doxoh commented 1 year ago

@WhishN can u confirm on latest dev?

WhishN commented 1 year ago

Just tested with:

alt:V build #15.0-dev539, branch dev
AltV.Net.Client 15.0.143-dev

// Enter
[19:50:29] [\.] OnCheckpoint True
[19:50:29] [\.] OnCheckpoint True
// Exit
[19:50:39] [\.] OnCheckpoint True
[19:50:39] [\.] OnCheckpoint False

Still happening pls tag on discord if u need answer quick :D

Doxoh commented 1 year ago

fixed