search

FabienPennequin / FPNTagBundle

This bundle allows to tag your Doctrine entities easily
http://knpbundles.com/FabienPennequin/FPNTagBundle
76 stars 50 forks source link

[README] Adding a bsic README file for the bundle #1

Closed weaverryan closed 13 years ago

weaverryan commented 13 years ago

Hey Fabien!

I ran across your bundle when I was in need of some tagging, and it's worked wonderfully. I wanted to get together a quick README for the bundle. It's probably not perfect, so if you spot anything, let me know.

Also, one thing that neither the bundle nor the extension addresses is querying for your tagged entities. I've created a few basic methods in a TagRepository in my application, and I think they might be good candidates for an optional base TagRepository class that lives in the extension library. Thoughts?

Thanks for your work!

weaverryan commented 13 years ago

For some reason, your comments didn't come out next to where you meant them to. Still, I found the first and third issues and fixed them. But I'm not sure where the ORM annotation import is missing.

Thanks!

FabienPennequin commented 13 years ago

My first comment is also missing :/ So I said that I wrote a TagRepository too but it needs more work to make it more generic before moving it in the extension library. I do not know when I have time to do this, so feel free to share yours if you wish. :)

The missing ORM annotation is for your Post entity. I think that a "use Doctrine\ORM\Mapping as ORM" is missing.

Thanks you Ryan! Your help is greatly appreciated.

weaverryan commented 13 years ago

Ah, I see the missing ORM import- good catch, I've added it.

I'll take a look and see if my repository class is sufficiently independent and valuable. If it is, I'll pull against your extension library.

Thanks again!