search

FabienPennequin / FPNTagBundle

This bundle allows to tag your Doctrine entities easily
http://knpbundles.com/FabienPennequin/FPNTagBundle
76 stars 50 forks source link

Missing information in Readme.md #2

Closed proclamo-zz closed 12 years ago

proclamo-zz commented 13 years ago

In autoload.php:

$loader->registerNamespaces(array( ...

'DoctrineExtensions' => DIR.'/../vendor/doctrine-extensions-taggable/lib',

));

and in app/config.yml:

fpn_tag: model: tag_class: FPN\TagBundle\Entity\Tag tagging_class: FPN\TagBundle\Entity\Tagging

leevigraham commented 12 years ago

This also fixed my issue but raises another one (I think).

I don't think the autoloader should use 'DoctrineExtensions' as the key. I'm also using @l3pp4rd's doctrine extensions implemented in Symfony2 by @stof.

I'm still feeling my way around Symfony2 so I can't offer a pull request or clearly identify the issue. Happy to be told that I'm wrong but isn't there a chance of naming conflicts when using 'DoctrineExtensions'?

stof commented 12 years ago

There is a conflict as DoctrineExtensions is already used as namespace by @beberlei (who is Doctrine lead dev)

l3pp4rd commented 12 years ago

Yes, try to think some vendor namespace of your own, it will conflict otherwise

leevigraham commented 12 years ago

@stof / @l3pp4rd Thanks for confirming my initial thoughts. Time to look deeper into DI so I can create a PR :D

leevigraham commented 12 years ago

I've created a separate issue for the potential autoloader conflict naming here: https://github.com/FabienPennequin/FPNTagBundle/issues/3

stof commented 12 years ago

Well, the first step is not about DI. It is about changing the namespace of the related library to something else. And this should be let to the owner so that he choose the name he wants to use.