search

FabienPennequin / FPNTagBundle

This bundle allows to tag your Doctrine entities easily
http://knpbundles.com/FabienPennequin/FPNTagBundle
76 stars 50 forks source link

Conflict in autoloader naming. #3

Closed leevigraham closed 12 years ago

leevigraham commented 12 years ago

Repasted from: https://github.com/FabienPennequin/FPNTagBundle/issues/2#issuecomment-2729202

This also fixed my issue but raises another one (I think).

I don't think the autoloader should use 'DoctrineExtensions' as the key. I'm also using @l3pp4rd's doctrine extensions implemented in Symfony2 by @stof.

I'm still feeling my way around Symfony2 so I can't offer a pull request or clearly identify the issue. Happy to be told that I'm wrong but isn't there a chance of naming conflicts when using 'DoctrineExtensions'?

stof commented 12 years ago

the issue should not been opened here. The bundle does not have any issue about namespace conflicts. The issue is with the related library.

And btw, you don't have any issue with @l3pp4rd's extensions as they don't use this namespace (the namespace is Gedmo). You would have some when using @beberlei's one though

stof commented 12 years ago

btw, reading your message again, I think you misunderstood what the autoloader config is. The autoloader does not choose what is used a key. The key is the namespace for which it is registered, and so it depends of what is used in the code you want to load.

leevigraham commented 12 years ago

I'll move it to the manager.