Use Fisher 4.x - Githubissues

FabioAntunes / fish-nvm

nvm wrapper for fish-shell

MIT License

511 stars 20 forks source link

Use Fisher 4.x #52

Closed jorgebucaran closed 3 years ago

jorgebucaran commented 3 years ago

The latest Fisher is no longer compatible with OMF.

jorgebucaran commented 3 years ago

@FabioAntunes Ready to merge here?

FabioAntunes commented 3 years ago

I'm not sure why the fact that the latest fisher not being compatible with OMF, makes my plugin not compatible as well?

this is still valid and has nothing to do with fisher:

omf install https://github.com/fabioantunes/fish-nvm    
omf install https://github.com/edc/bass

jorgebucaran commented 3 years ago

You're probably right, but double-check:

OMF-specific init.fish and uninstall.fish files are no longer supported by Fisher
OMF doesn't support conf.d snippets

If you're not planning to use any of that ever, then you're probably right!

Now, it's ultimately up to you, but I feel that leading newcomers to OMF isn't a great idea. The project is completely inactive. Long-standing issues remain open even after years. Don't agree? No worries! I'm just proposing we don't send people to OMF.

FabioAntunes commented 3 years ago

I'm not sending people to anywhere, just providing installation guidelines. Just as any vim plugin will have installation guidelines for a bunch of plugin managers.

FabioAntunes commented 3 years ago

I have removed the fishfile and updated fisher installation guidelines from add to install.

Thanks for your help anyway

jorgebucaran commented 3 years ago

I totally understand your position. Thanks!