Open guidoagapito opened 1 month ago
n_subap in pupdata and in pyr_slopec is not coherent:
self.n_subap = self._pupdata.ind_pup.shape[0]
return self._ind_pup.shape[1] // 4
I think that in pupdata it should be
return self._ind_pup.size() / 4
or
return self._ind_pup.shape[0]
so it will be coherent with pyr_slopec. Then a lot of method of pupdata should change:
e.g.
self._ind_pup = self.xp.empty((4, 0), dtype=int)
should be
self._ind_pup = self.xp.empty((0, 4), dtype=int)
and
def single_mask(self): f = self.xp.zeros(self._framesize, dtype=self.dtype) f[self._ind_pup[:, 0]] = 1 return f
Just to report a couple of examples.
n_subap in pupdata and in pyr_slopec is not coherent:
self.n_subap = self._pupdata.ind_pup.shape[0]
return self._ind_pup.shape[1] // 4
I think that in pupdata it should be
return self._ind_pup.size() / 4
or
return self._ind_pup.shape[0]
so it will be coherent with pyr_slopec. Then a lot of method of pupdata should change:
e.g.
self._ind_pup = self.xp.empty((4, 0), dtype=int)
should be
self._ind_pup = self.xp.empty((0, 4), dtype=int)
and
Just to report a couple of examples.