search

FabioZumbi12 / UltimateChat

Ultimate and advanced Chat for Bukkit and Sponge
GNU General Public License v3.0
31 stars 33 forks source link

Fixes for Sponge repo and Bukkit world creation #334

Closed TylerS1066 closed 3 years ago

TylerS1066 commented 3 years ago

Firstly, this PR "fixes" #333, but does nothing to fix the problems with the Sponge 8 module. I merely removed any problem code in my local environment to allow myself to build a functional spigot plugin.

Secondly, it "fixes" #332. The problem stems from getServer().getPluginCommand("tell") returning null when plotsquared loads the plot world. I'm not sure how UChat should handle this, so I merely threw a warning message into the console.

THIS IS NOT A SERIOUS PR, I merely am making it to document for @FabioZumbi12 what is wrong with the plugin and what I had to do to fix it. I would highly appreciate it if this could be looked into by somebody who actually knows the UChat code and knows how to properly deal with this, rather than me coming in with a hacksaw.

FabioZumbi12 commented 3 years ago

Thanks for the fix! I will not accept the PR because i have already fixed the maven repo locally. Just forgot to upload the changes. This way, your PR conflicts with my local changes.

Btw, i have applied the fix for worldreload bug!! Thank you for you time <3

TylerS1066 commented 3 years ago

Thank you for the prompt response!

I did a quick test and the fix does appear to allow UChat to load.