search

Fable-Fauna / Fable.Flora

Css theme type provider and tools
MIT License
59 stars 3 forks source link

Support external css files #17

Closed Zaid-Ajaj closed 5 years ago

Zaid-Ajaj commented 5 years ago

Hello there,

This PR adds the possibility of loading a CSS file from an external source such as stylesheet from CDN which makes it easier to test out the provider. I haven't been able to test it properly but it should work. It checks whether the file parameter starts with http(s):// in which case it loads the content using http, otherwise it loads from the local file system

Also small fixes for a couple of pattern match cases that weren't handled (plus auditing the npm packages with npm audit fix)

musheddev commented 5 years ago

Looks good and thanks a lot. I will try to merge and release a bit later.

musheddev commented 5 years ago

Released to 0.6.3 and looks like it works.

Zaid-Ajaj commented 5 years ago

Thank you! :heart: