Faboslav / friends-and-foes

Minecraft mod that adds outvoted and forgotten mobs from the mob votes in a believable vanilla plus style.
https://www.curseforge.com/minecraft/mc-mods/friends-and-foes
Other
95 stars 28 forks source link

Heavily damage chunk loading #196

Closed zoqin closed 4 months ago

zoqin commented 5 months ago

Minecraft version information

1.20.1

Mod loader information

Forge

Mod loader version information

47.2.0(forge) or 47.1.97(forge)

Mod version information

2.0.7 or 2.0.8 or 2.0.9

Expected Behavior

I should ba able to render/load chunk or at least be able to load/render them after a moment

Actual Behavior

After going forward for 1 or 2 min

image

Going a bit further

image

stoping the fly mode to touch chunk trying to facilitate script to understand which chunk load make me go through the map

image

in my back I can see entity rendered in already loaded chunk

image

At the boarder block seems to be generated but not rendering

image

Reproduction Steps

  1. Add mod to minecraft
  2. Launch the game in creative (to see the effect faster of a mod or benchmark a modpack performance)
  3. Move forwarde for 5 min
  4. add or remove Friend & Foe from your modpack to block or unblock chunck loading

Screenshots & files

First mod pack

Second modpack

Third modpack (not a stable modpack overall)

Too long for the comment tell me if you need it

Faboslav commented 5 months ago

Hello, this is probably fault of another mod, can you provide logs while getting unloaded chunks? Is there anything related to friends&foes in the logs?

zoqin commented 5 months ago

Hello, thanks for the answer

Saddly i don't know how to read properly logs I don't know if anything is related to friends&foes in the log but not loading friends&foes fix the issue leading to my theory

Here is a new fresh try (modpack 2+ F&F-2.0.9) (tell me if I can provide more) image

log.txt

zoqin commented 5 months ago

Im am leading further experiment (loading in a different order one at a time) and at this point I can say that its not F&Foe that made me unable to load chunk, am I still experimenting to see if its a conflict or if it was pure coincidence that lead to the bug everytime I had F&Foe

Sorry for the false alarme I hope it didn't bother you I will communicate on the mater as soon as I have a better understanding of the issue

Faboslav commented 5 months ago

That's fine, let me know if you find something related :).

zoqin commented 4 months ago

After a lot of experimentation I found that my issue was garbage collection, allocating to much ram didn't triggered GC enough and when it did he would instantly froze the internal server. The only things that change when Friends and Foe was enable was to use just enough ram to trigger GC quickly on my benchmark briking the world generation

Exploring long enough with other mod triggered the same issue once the GC finally triggered

The solution is to lower RAM allocation to trigger GC more often so Java don't froze while processing the high amount of data, I was allocating 20go and I crank it back down to 12go, making other garbage collection optimization would probably help, as long as Java doesn't need to handle 20Go at once

As such I close the issue and thank you for your open mind

Im excited to experience your mod in my custom modpack and to share it with other Have a great day