Closed martindale closed 4 years ago
Merging #16 into master will decrease coverage by
35.25%
. The diff coverage is27.62%
.
@@ Coverage Diff @@
## master #16 +/- ##
===========================================
- Coverage 64.59% 29.34% -35.26%
===========================================
Files 9 7 -2
Lines 435 501 +66
Branches 66 82 +16
===========================================
- Hits 281 147 -134
- Misses 154 354 +200
Impacted Files | Coverage Δ | |
---|---|---|
services/slack.js | 2.6% <0.88%> (ø) |
|
services/matrix.js | 2.73% <1.12%> (-24.1%) |
:arrow_down: |
lib/doorman.js | 67.85% <66.97%> (-10.18%) |
:arrow_down: |
lib/plugin.js | 69.44% <68.57%> (+0.21%) |
:arrow_up: |
services/discord.js | 18.75% <7.14%> (ø) |
|
lib/router.js | 89.47% <89.18%> (-1.16%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4ec4897...7ec9891. Read the comment docs.
So much cleaner class based architecture. Love the changes
Coverage needs to be improved before this is merged.
Final work for
0.1.1
, including upstreaming components of Doorman's messaging protocol into@fabric/core
, and a complete migration to ES6 — documentation now following Fabric guidelines and available locally vianpm run docs
!