FabricLabs / doorman

Say hello to Doorman, your made-to-fit community manager. Simple API, feature-rich plugins, and more.
https://chat.fabric.pub
MIT License
10 stars 5 forks source link

Initial Review of 0.2.0 Changes #18

Closed martindale closed 3 years ago

martindale commented 4 years ago

Merge this pull request to update develop, change base branch from master to begin work.

TODO:

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@1520896). Click here to learn what that means. The diff coverage is 1.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #18   +/-   ##
==========================================
  Coverage           ?   35.56%           
==========================================
  Files              ?       11           
  Lines              ?      582           
  Branches           ?       94           
==========================================
  Hits               ?      207           
  Misses             ?      375           
  Partials           ?        0
Impacted Files Coverage Δ
services/slack.js 3.44% <0.88%> (ø)
services/matrix.js 3.26% <1.11%> (ø)
services/discord.js 18.75% <7.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1520896...da9ab25. Read the comment docs.

martindale commented 4 years ago

In addition to a few other common services, we're now exposing Matrix as a service in @fabric/core: https://github.com/martindale/fabric/pull/33/files#diff-6ca2aec49f5865a0c448fd96173a7b01