search

FabricMC / Enigma

This is a fork of cuchaz's Enigma, a deobfuscation/remapping tool for Java software.
GNU Lesser General Public License v3.0
445 stars 116 forks source link

Some fully mapped classes still report unmapped things in the Mappings Stats dialog #502

Open PiTheGuy opened 1 year ago

PiTheGuy commented 1 year ago

This mainly applies to enums, but I have found other cases.

Example: The following class reports 3 unmapped parameters image

jordanamr commented 1 year ago

Can confirm, but it's probably because Enigma doesn't know if the unmapped enum is because of a misconfiguration or not, basically I think it doesn't know if it's... already unmapped or not ?

NebelNidas commented 1 year ago

Probably because the enum's values and valueOf methods are technically still considered unmapped. But you can't rename them anyway, and the decompiler doesn't even show them

PiTheGuy commented 1 year ago

The methods it's counting that it shouldn't are Enum.values, Enum.valueOf, Enum.<init>, Record.equals, and Record.<init>. Edit: It's actually only the first 2 parameters of Enum.<init>.