FabricMC / Enigma

This is a fork of cuchaz's Enigma, a deobfuscation/remapping tool for Java software.
GNU Lesser General Public License v3.0
426 stars 112 forks source link

Fix ghost entries caused by packages becoming empty #517

Closed NebelNidas closed 1 year ago

NebelNidas commented 1 year ago

Fixes #471. The current code's issue is that entry.getPackageName() here: https://github.com/FabricMC/Enigma/blob/08d9e28bdc00ac7846e551e5eef7ebf9ffc63b74/enigma-swing/src/main/java/cuchaz/enigma/gui/NestedPackages.java#L92-L93 already returns the new package name, not the old one, which is required. We can circumvent this by simply using the UI node's parent instead, which still points to the old entry.