Closed YanisBft closed 1 year ago
Should we consider checkcast instruction as well?
Should we consider checkcast instruction as well?
Good idea, now done
Hmm, checkcast
would catch some of the "invisible" casts done for generic objects, like when getting an element from a list with a specific type
Hmm,
checkcast
would catch some of the "invisible" casts done for generic objects, like when getting an element from a list with a specific type
These casts are invisible with Procyon, but seem to appear with CFR. Should I revert?
I don't think it's a huge issue. The generics checkcast
s are references to that type after all :smile:
Why care about the specific opcodes rather than just considering every TypeInsnNode?
Until now, Enigma only indexed class references through constructor methods. With this PR, it now indexes class references in 3 more ways:
instanceof
MyClass.class
), which fixes #26