search

FabricMC / community

Docs, tags and orchestration.
Other
10 stars 42 forks source link

Update jdk.ytag #72

Closed Yoosk closed 2 years ago

Yoosk commented 3 years ago

AdoptOpenJDK is moving to the Eclipse Foundation and rebranding. July 2021 and future releases will come from Adoptium.net

modmuss50 commented 3 years ago

Would it be better to point users in the direction of Microsoft’s versions? I have seen a few users unsure if the adopt open jdk builds are legit due to the lesser know source.

I’d be interested to see what other people think?

ghost commented 3 years ago

Sounds like Microsoft's JDK builds are using Adoptium's as a base: https://www.microsoft.com/openjdk, however since Microsoft does have Java 16 builds released now it may be wise to promote them as they are likely the builds Mojang are using.

Yoosk commented 3 years ago

True that, i was used to AdoptOpenJDK ones but it might be better to go with Microsoft as it is really known by your average user.

intact commented 3 years ago

Adoptium.net page is simple to use

modmuss50 commented 3 years ago

IMO the biggest issue with the MS builds is the download page isnt super user friendly as they have to pick the correct version: https://docs.microsoft.com/en-gb/java/openjdk/download

Amazon's corretto has the same issue: https://aws.amazon.com/corretto/

liach commented 2 years ago

The jdk mojang ships is oracle jdk (can be confirmed by typing java -version and it shows Java (TM), and it ships javac); I would recommend using the oracle jdk directly for better compatibility or use the base openjdk from openjdk.java.net than those from other sources.

UpcraftLP commented 2 years ago

The jdk mojang ships is oracle jdk

That's only true for java 8. The java 16 JDK is by Microsoft.

 C:\Program Files (x86)\Minecraft Launcher\runtime\java-runtime-alpha\windows-x64\java-runtime-alpha\bin> ./java -version
openjdk version "16.0.1" 2021-04-20
OpenJDK Runtime Environment Microsoft-22300 (build 16.0.1+9)
OpenJDK 64-Bit Server VM Microsoft-22300 (build 16.0.1+9, mixed mode)
modmuss50 commented 2 years ago

I will merge this for now, we can look at moving to MS's another time.