FabricMC / fabric-docs

[WIP] Official curated documentation for Fabric, a modding toolchain for Minecraft.
https://docs.fabricmc.net
Other
39 stars 39 forks source link

Use different `ThemeConfig` for each locale #100

Closed its-miroma closed 3 weeks ago

its-miroma commented 1 month ago

Fix #95

netlify[bot] commented 1 month ago

Deploy Preview for nimble-elf-d9d491 ready!

Name Link
Latest commit 95865ab87ed66e63b412da118c6ade8181e925f4
Latest deploy log https://app.netlify.com/sites/nimble-elf-d9d491/deploys/6669f1bd83cbc600086b0db9
Deploy Preview https://deploy-preview-100--nimble-elf-d9d491.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

its-miroma commented 1 month ago

The preview doesn't currently work for other languages because their files still use absolute links.

Update: it fixes the top bar, but not the pages

its-miroma commented 1 month ago

I asked for help over at Vitepress, and they told me that we were doing it wrong.

I have fixed it now, but there is some refactoring I would like to do. I do not have time for that right now, I'll see when I can do it.

I also don't know what I should do with the CONTRIBUTING.md files in translated/; I moved them to the lowercase version in a separate commit, if that's correct, otherwise I'll drop it.

its-miroma commented 1 month ago

Some people on Crowdin have started using absolute language links to fix the problem on their end. Again, should I modify their files here on GitHub? Can I touch translated/?

https://github.com/FabricMC/fabric-docs/blob/39cad1fa0f7d1f64701f0595d3d4f71ea783f494/translated/ru_ru/index.md?plain=1#L26

(PS: I do not speak Russian)

IMB11 commented 1 month ago

Some people on Crowdin have started using absolute language links to fix the problem on their end. Again, should I modify their files here on GitHub? Can I touch translated/?

We really need to find a way to convey the contributing guidelines to users on Crowdin, as there's no way to do this other than make the contributor process invite-only.

IMB11 commented 1 month ago

I dont think this implementation will work with versioning, please test it out if you can.

RushanM commented 1 month ago

Does this mean that we need to stop using absolute links now?

IMB11 commented 1 month ago

Does this mean that we need to stop using absolute links now?

You should have always been using relative links in translations.

its-miroma commented 1 month ago

I dont think this implementation will work with versioning, please test it out if you can.

It didn't. https://github.com/IMB11/vitepress-versioning-plugin/pull/4 Update: waiting for release Update: Released

IMB11 commented 3 weeks ago

Will publish a version for you now.

IMB11 commented 3 weeks ago

0.11.0 is out, update when you can :+1:

IMB11 commented 3 weeks ago

Actually i'll do it now when adding support for nav translations

IMB11 commented 3 weeks ago

I think we should merge this without the localisation of the version switcher for now, it can come at a later date.

IMB11 commented 3 weeks ago

LGTM @modmuss50