Closed IMB11 closed 3 days ago
Should be good for review now, please have a thorough read of the pages that have changed:
Other than that, it's been pretty easy to update everything to 1.21, the versioning system works like a charm and the script works great at automating the bulk of the process. This only took 2ish hours, which is good considering it's the first time we've updated to a new version.
Question: How is translation going to work? I assume the translations for the older versions are now set in stone?
I like the warning / "This page is written for:" card on the older versions, not sure it really adds much on the latest version? Maybe could be a bit smaller or something, its very much a nit pick. Its great to see this system working 👍 Ill take a proper look at this PR soon.
Yup, they're set in stone, we could enable translations for versioned pages but I don't see a way on how to configure it properly in the crowdin.yml.
Also, if translations of versioned content is enabled, whenever we update the wiki, the crowdin string count would pretty much double, and thats not really good, as it lags the crowdin editor and you'd have to constantly bug the crowdin team for an open source string limit increase.
I like the warning / "This page is written for:" card on the older versions, not sure it really adds much on the latest version? Maybe could be a bit smaller or something, its very much a nit pick. Its great to see this system working 👍 Ill take a proper look at this PR soon.
It's mostly temporary until I can develop an actual version switcher component. The next vitepress update is adding support for custom components within navigation bars which should allow me to do this. I agree it could be a bit smaller on latest pages though.
Yup, they're set in stone
Ok, great thats what I was going to suggest, I was worried about the string count. (I am yet to send that email :D) If there are issues or mistakes that urgently need fixing that can be done via github.
✅ Deploy Preview for nimble-elf-d9d491 ready!
Toggle QR Code...
Use your smartphone camera to open QR code link.
To edit notification comments on pull requests, go to your Netlify site configuration.