search

FabricMC / fabric-example-mod

Example Fabric mod
Creative Commons Zero v1.0 Universal
1.67k stars 942 forks source link

Update Gradle version and Fabric dependencys #240

Closed backryun closed 1 year ago

backryun commented 1 year ago

Gradle 8.0 released, so I test example mod on Gradle 8.0 No build error, works fine on Minecraft. And the mod targeted 1.19.3 so I updated Fabric dependencys(Loader,API,yarn). I hope this commit intergrate on this project.

RawDiamondMC commented 1 year ago

It seems that gradle was updated to 8.0.1,will you update gradle to 8.0.1?

backryun commented 1 year ago

It seems that gradle was updated to 8.0.1,will you update gradle to 8.0.1?

Of cource!

RawDiamondMC commented 1 year ago

It seems that gradle was updated to 8.0.1,will you update gradle to 8.0.1?

Of cource!

I saw that #222 use gradlew wrapper --gradle-version=7.6 , maybe you need run gradlew wrapper --gradle-version=8.0.1 to update?(maybe run this code will add more things?)

modmuss50 commented 1 year ago

Hi, Thanks for this PR however its not quite right as it does not update the gradle wrapper, and the required loader version. Due to the recent report of supply chain attacks on the Gradle wrapper I have gone ahread and updated this myself.

See: https://github.com/FabricMC/fabric-example-mod/compare/86fc994be16b...3bf9aa7f113f

Thanks again for the PR 👍