search

FabricMC / fabric-example-mod

Example Fabric mod
Creative Commons Zero v1.0 Universal
1.66k stars 933 forks source link

Appropriately deal with line endings in scripts #272

Closed sydist closed 10 months ago

modmuss50 commented 10 months ago

This repo is automatically generated from https://github.com/FabricMC/fabricmc.net/tree/main/scripts/src/lib/template/templates the change should be made there. I wonder if its also worth having it as:

* text=auto eol=lf
*.bat text eol=crlf

So all text files are lf? other than the .bat file?

sydist commented 10 months ago

I see where you're coming from, but I don't think source files should be involved as the conversion is already handled by default in the newer versions of Git using core.autocrlf. The default gradle init does this too, so I think it should be sufficient.

sydist commented 10 months ago

I'll move this to fabricmc/fabricmc.net

sydist commented 10 months ago

https://github.com/FabricMC/fabricmc.net/pull/74