FabricMC / fabric-installer

An Installer for Fabric. For the vanilla launcher
Apache License 2.0
102 stars 66 forks source link

Fabric Installer crashes when I try to pick a folder #126

Closed Eatham532 closed 11 months ago

Eatham532 commented 11 months ago

hs_err_pid3360.log

There isn't much else to say here. Hopefully the logs help

modmuss50 commented 11 months ago

This might sound odd, but do you have a "God Mode" shortcut on your desktop or another location? These special folder names are actually called "Junction Points", and cause a crash in Java 8 or 9.

See the JDK bug about this here: https://bugs.openjdk.org/browse/JDK-8179014

The installer is being launched using Java 8, however I do also see that you have Java 17 and 11 installed, and Java 17 is set as you JAVA_HOME version, whats intresting is our installer bootstrap should be using JAVA_HOME before trying to use java from the path 🤔

Eatham532 commented 11 months ago

Surprisingly yeh, I do have God Mode. That is really odd that Java 8 does that. (Don't have 9).

Edit: Actually does make sense because java does not use the normal file picker interface so then would have to index the directories itself.

modmuss50 commented 11 months ago

Going to close this as there isnt anything we can do to fix it. Running the installer with a newer Java is a sutible fix.