FabricMC / fabric-installer

An Installer for Fabric. For the vanilla launcher
Apache License 2.0
102 stars 66 forks source link

Installer fails if the mods folder is a symlink #132

Closed f-michaut closed 6 months ago

f-michaut commented 9 months ago

Today i've decided to update Fabric, so I downloaded the installer again, and re-installed it for the same MC version, but a newer Fabric version.

All was going well, until the installer failed while creating the mods folder. I have the mods folder has a symlink on my system for ease of mod management.

I believe the error is because the installer checks that the folder exists and is a folder, so if it is a symlink, it considers it non-existant and tries to create it but it fails cause there is already a node with that name (the symlink).

To fix it, I just had to rename the mods symlink to something else, run the installer, and rename it back. But it would be nice if the installer could check for a symlink pointing to a directory as well.