FabricMC / fabric-language-kotlin

Fabric language module for Kotlin.

Apache License 2.0

293 stars 33 forks source link

update Kotlin to 1.4.0 #21

Closed NikkyAI closed 4 years ago

NikkyAI commented 4 years ago

this took a while to work, multiple restarts and cleaning of caches but eventually it just worked with almost the same code as before

modmuss50 commented 4 years ago

I have added github actions so we can test this stuff a bit more. Right now this branch doesnt even build or import into idea.

NikkyAI commented 4 years ago

yeah there is some incredible weirdness going on because it works fine locally for me

NikkyAI commented 4 years ago

I guess it was the fault of refreshVersions plugin.. even though it works fine for all my non fabric projects and i was sure i tested this same thing before.. now it makes github actions build sucessfully

either way

ready to merge

NikkyAI commented 4 years ago

well i fucked up and accidenatlly pushed on the wrong origin...

modmuss50 commented 4 years ago

I will remove the build, if you can open another PR and let me know if its ready for a final review we can get this in.