FabricMC / fabric-language-kotlin

Fabric language module for Kotlin.
Apache License 2.0
293 stars 33 forks source link

Automatic version update #84

Closed deirn closed 2 years ago

deirn commented 2 years ago

Test PR: https://github.com/deirn/flk-automation-test/pull/4

jakobkmar commented 2 years ago

What I worry about here is that often the newest versions are not the ones that match, meaning only a human can update them to the correct combination at some points in time.

modmuss50 commented 2 years ago

Yeah, my main worry is that this seems like it will open PRs for pre-release versions.

deirn commented 2 years ago

Yeah, my main worry is that this seems like it will open PRs for pre-release versions.

Shouldn't happen if kotlin dev stick to somewhat semver (dash suffix for pre-releases), it only compare versions without it.

What I worry about here is that often the newest versions are not the ones that match, meaning only a human can update them to the correct combination at some points in time.

Did that ever happened before? What FLK includes are official libraries, kotlin dev should already know if one of their libs would be incompatible, no? If we are that paranoid, we can leave the generated PR open for a few days and let the bot update the pr branch, it should only open one pr at a time.